Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Generator - new website #7981

Merged
merged 9 commits into from
Jul 12, 2022
Merged

Code Generator - new website #7981

merged 9 commits into from
Jul 12, 2022

Conversation

dimaMachina
Copy link
Collaborator

@dimaMachina dimaMachina commented Jun 28, 2022 •
edited
Loading

  • Read more banner link is not clickable

image

  • The previous version of <CodeTabs> component was keeping the selected language/framework in LocalStorage, it is not the case anymore

image

To reproduce: go to the docs index, select "Vue Apollo" at the first code example, scroll to the second, "URQL React" is selected 🔴

  • The Plugin styling (with tables) is not optimal

image

  • On the Plugin Hub index, maybe we should have "right arrow" instead of "bottom arrow"? the current one makes feel it should open a menu

image

@changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e707598

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
graphql-code-generator ✅ Ready (Inspect) Visit Preview Jul 12, 2022 at 0:41AM (UTC)

@Urigo
Copy link
Collaborator

Urigo commented Jun 28, 2022

I've merged this, just to make sure we keep track: #7909

@dimaMachina
Copy link
Collaborator Author

@Urigo Don't worry, I'll make a rebase with master once everything is fine with new website

@charlypoly
Copy link
Contributor

@B2o5T I'll look into the Algolia search script + components tomorrow 👀

@charlypoly
Copy link
Contributor

@B2o5T Also we need to put redirects or change the root path of the plugins hub (a lot of external links on that: blogposts, etc)

Ex: https://graphql-code-generator-a12gixdiw-theguild.vercel.app/plugin-hub/typescript/typescript

@dimaMachina
Copy link
Collaborator Author

@B2o5T Also we need to put redirects or change the root path of the plugins hub (a lot of external links on that: blogposts, etc)

Ex: https://graphql-code-generator-a12gixdiw-theguild.vercel.app/plugin-hub/typescript/typescript

I didn't forget to add all new redirects :) https://github.com/dotansimha/graphql-code-generator/pull/7981/files#diff-02a351de4c8e66a0c9e62bd22b54e65e3ff7133ab407a20b8b82f006bb22feaeR10-R15

@github-actions

This comment was marked as off-topic.

Sign in to view
@dotansimha dotansimha changed the title new docs New docs and website based on Nextra Jul 4, 2022
@dimaMachina dimaMachina marked this pull request as ready for review July 4, 2022 10:03
@charlypoly
Copy link
Contributor

@B2o5T but is it necessary to have this new path in the first place? why not uses the previous /plugins ?

@dimaMachina
Copy link
Collaborator Author

@B2o5T but is it necessary to have this new path in the first place? why not uses the previous /plugins ?

So as @kamilkisiela proposed let's rename Plugins Hub to Plugins and path to /plugins?

dimaMachina and others added 7 commits July 11, 2022 21:42
@dimaMachina
nextra setup
fa6a7e4 
move getting-started/index.mdx

move getting-started/installation.mdx

move getting-started/development-workflow

move guides/further-reading

getting-started/index.mdx

move to src/pages/docs

getting-started/installation.mdx

guides/react

getting-started/vue.mdx

getting-started/angular.mdx

getting-started/svelte.mdx

getting-started/front-end-typescript-only.mdx

getting-started/apollo

getting-started/graphqlmodules.mdx

getting-started/angular.mdx

move config-reference

docs/config-reference/codegen-config

getting-started/schema-field.mdx

getting-started/documents.mdx

getting-started/config-field.mdx

getting-started/require-field.mdx

getting-started/naming-convention.mdx

getting-started/lifecycle-hooks

move advanced

advanced/generated-files-colocation

remove isDev

advanced/programmatic

advanced/how-does-it-work

advanced/profiler

move integrations

all integrations

custom codegen

custom-codegen

migration

setup plugins page

fixes

fixes

fixes

patch

temp-styles

ok, styles works

react-apollo, react-query, resolvers

operations, oclif

new plugins migrated

migrate new plugins

new plugins

migrate plugins

migrate plugins

migrate plugins

migrate plugins

migrate apollo-angular and client-helpers to typescript folder

c-sharp migrate

flow in folder

move presets

move other

migrate java

move typescripts

move typescripts

move typescripts

add plugin hub page, fix layout: raw

ok it's works

remove unused deps

generate config schema

add legacy redirects

add patches for nextra

fix deploy

yet another fix

remove <OperationsNote/>

enhance code-blocks with filename

prettier

use latest next and guild-components
@charlypoly @dimaMachina
refactor(scripts): Algolia scripts now supports Nextra (#8011)
0f07b51
@dimaMachina
rebase fixes
e4b3e56
@dimaMachina
rename plugin hub to plugins
2dc260f
@dimaMachina
fix typescript plugins titles
5a10b59
@dimaMachina
fix rest of titles
8293c97
@dimaMachina
add patches
194dde2
@saihaj saihaj merged commit b1d7d91 into master Jul 12, 2022
@saihaj saihaj deleted the nextra branch July 12, 2022 13:14
saihaj added a commit that referenced this pull request Jul 12, 2022
@saihaj
Revert "New docs and website based on Nextra (#7981)"
ef95f45 
This reverts commit b1d7d91.
@saihaj saihaj mentioned this pull request Jul 12, 2022
Merged
saihaj added a commit that referenced this pull request Jul 12, 2022
@saihaj
Revert "New docs and website based on Nextra (#7981)" (#8083)
ed07ffb 
This reverts commit b1d7d91.
@saihaj saihaj restored the nextra branch July 12, 2022 13:19
@saihaj saihaj deleted the nextra branch July 12, 2022 13:19
saihaj added a commit that referenced this pull request Jul 12, 2022
@saihaj
Revert "Revert "New docs and website based on Nextra (#7981)" (#8083)"
88962f9 
This reverts commit ed07ffb.
saihaj added a commit that referenced this pull request Jul 12, 2022
@saihaj
New docs and website based on Nextra (#7981)
aa0b906 
This reverts commit ed07ffb.
@dimaMachina dimaMachina changed the title New docs and website based on Nextra Code Generator - new website Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

Assignees

@dimaMachina dimaMachina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dimaMachina @Urigo @charlypoly @saihaj